[PATCH] Fix "Dialer: Error setting antenna power" failure at
philipp.zabel at gmail.com
Fri Sep 28 21:07:52 CEST 2007
On 9/28/07, Mike (mwester) <mwester at dls.net> wrote:
> Current images are crippled because the dailer fails at startup with the
> message "Dialer: Error setting antenna power".
> This problem is traced back to a recent change committed to OE that adds
> error-checking logic to the read/write calls in libgsmd. Basically,
> lgsm_send_simple() calls lgsm_send(), and expects the return value to be the
> number of characters sent. The recent patch to add error-checking changed
> lgsm_send() to return a 0 on success, which results in lgsm_send_simple()
> always returning the error code EIO on success.
> The patch below restores the old behavior for lgsm_send(), such that it
> returns the number of characters on succuss. Arguably it might be better to
> change the callers behavior such that they all expect the more-standard "0"
> return value for success.
Comparing with posix send(), I think returning the number of bytes
sent is the most consistent thing to do.
> (Unless anyone has any strong objections in the next day, I'll commit this
> simple fix to OE - at least as an interim solution so that we can get
> current images to function correctly again)
> Mike (mwester)
> --- gsm/src/libgsmd/libgsmd.c.orig 2007-09-25 00:41:56.000000000 -0500
> +++ gsm/src/libgsmd/libgsmd.c 2007-09-25 00:43:44.000000000 -0500
> -210,7 +210,7 @@
> pos += rc;
> - return 0;
> + return (sizeof(*gmh) + gmh->len);
> struct gsmd_msg_hdr *lgsm_gmh_fill(int type, int subtype, int payload_len)
More information about the gsmd-devel