Patch Committed, was Re: [patch] manufacturer, model, revision and serial

[Paulius Zaleckas]

I noticed that you did:
+	if (strncmp(resp, "+CGSN: ", 7))
+		return -EINVAL;

My Option GTM378 returns only serial number (without "+CGSN: ").
According to 3GPP TS 07.07 V7.8.0 section 5.4 this is how it should be...

If other(broken) modems answer with +CGSN:, then we should do it like this:
	if (!strncmp(resp, "+CGSN: ", 7))
		resp += 7;

This also applies to all phone info commands.

See attached patch which fixes these problems.

Regards,
Paulius Zaleckas

Erin Yueh wrote:
> Paulius Zaleckas wrote:
>> I have also removed lgsm_get_info declaration since we are not going 
>> to use it according to Sean Chiang.
>>
>> Regards,
>> Paulius Zaleckas
>> ------------------------------------------------------------------------
>>
>>   
> Hi Paulius,
> Thanks for your patches! I modified some parts to fit gsmd design. 
> Actually, we don't need to keep
> the phone information in gsmd and needn't to retrieve them in initial 
> settings. Why we store IMSI
> value in gsmd, it's for bug#1185. Also, if you are interested in more 
> detailed 'gsmd', you may read 
> http://wiki.openmoko.org/wiki/Gsmd/document wiki page.
> 
> Hi List,
> 
> R4066 is committed for fix atcmd buffer length. R4067 is committed for 
> retrieving phone information. 
> Regards,
> Erin
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_phone_info.patch
Type: text/x-patch
Size: 1873 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/gsmd-devel/attachments/20080215/ca01877d/fix_phone_info.bin