[patch 5/6] jbt6k74: Cleanup double register settings

Stefan Schmidt stefan at openmoko.org
Thu Oct 18 14:05:45 CEST 2007


Remove double register settings. Not listed in the data-sheet and it works fine
without them. Looks like a copy-and-paste error.

Signed-off-by: Stefan Schmidt <stefan at openmoko.org>

Index: linux-2.6.22.5/drivers/spi/jbt6k74.c
===================================================================
--- linux-2.6.22.5.orig/drivers/spi/jbt6k74.c	2007-10-15 21:17:05.000000000 +0800
+++ linux-2.6.22.5/drivers/spi/jbt6k74.c	2007-10-15 21:18:25.000000000 +0800
@@ -181,7 +181,6 @@
 	rc |= jbt_reg_write(jbt, JBT_REG_BOOSTER_OP, 0x56);
 	rc |= jbt_reg_write(jbt, JBT_REG_BOOSTER_MODE, 0x33);
 	rc |= jbt_reg_write(jbt, JBT_REG_BOOSTER_FREQ, 0x11);
-	rc |= jbt_reg_write(jbt, JBT_REG_BOOSTER_FREQ, 0x11);
 	rc |= jbt_reg_write(jbt, JBT_REG_OPAMP_SYSCLK, 0x02);
 	rc |= jbt_reg_write(jbt, JBT_REG_VSC_VOLTAGE, 0x2b);
 	rc |= jbt_reg_write(jbt, JBT_REG_VCOM_VOLTAGE, 0x40);
@@ -202,14 +201,12 @@
 	rc |= jbt_reg_write(jbt, JBT_REG_GAMMA1_FINE_2, 0x00);
 	rc |= jbt_reg_write(jbt, JBT_REG_GAMMA1_INCLINATION, 0x00);
 	rc |= jbt_reg_write(jbt, JBT_REG_GAMMA1_BLUE_OFFSET, 0x00);
-	rc |= jbt_reg_write(jbt, JBT_REG_GAMMA1_BLUE_OFFSET, 0x00);
 
 	if (!qvga) {
 		DEBUGP("entering VGA mode\n");
 		rc |= jbt_reg_write16(jbt, JBT_REG_HCLOCK_VGA, 0x1f0);
 		rc |= jbt_reg_write(jbt, JBT_REG_BLANK_CONTROL, 0x02);
 		rc |= jbt_reg_write16(jbt, JBT_REG_BLANK_TH_TV, 0x0804);
-		rc |= jbt_reg_write16(jbt, JBT_REG_BLANK_TH_TV, 0x0804);
 
 		rc |= jbt_reg_write(jbt, JBT_REG_CKV_ON_OFF, 0x01);
 		rc |= jbt_reg_write16(jbt, JBT_REG_CKV_1_2, 0x0000);
@@ -232,11 +229,6 @@
 		rc |= jbt_reg_write(jbt, JBT_REG_ASW_TIMING_2_QVGA, 0x0a);
 	}
 
-#if 0
-	rc |= jbt_reg_write16(jbt, JBT_REG_HCLOCK_QVGA, 0x00ff);
-	rc |= jbt_reg_write16(jbt, JBT_REG_HCLOCK_QVGA, 0x00ff);
-#endif
-
 	return rc;
 }
 

-- 



More information about the neo1973-hardware mailing list