Simplifying the mixer

Joerg Reisenweber joerg at openmoko.org
Tue Jun 10 23:46:10 CEST 2008


Am Di  10. Juni 2008 schrieb Mike Montour:
> One of the difficulties in working with the Neo1973 audio subsystem is 
> the complexity of the wm8753 chip. I have attached a couple of patches 
> that I wrote to simplify this situation.

-SOC_DOUBLE_R("PCM Volume", WM8753_LDAC, WM8753_RDAC, 0, 255, 0),
+SOC_DOUBLE_R_TLV("PCM Volume", WM8753_LDAC, WM8753_RDAC, 0, 255, 0, dac_tlv),
 
-SOC_DOUBLE_R("ADC Capture Volume", WM8753_LADC, WM8753_RADC, 0, 255, 0),
+SOC_DOUBLE_R_TLV("ADC Capture Volume", WM8753_LADC, WM8753_RADC, 0, 255, 0, 

Hi Mike!
Could I speak you into doing a little fancy and augmenting the controls' names 
(like "PCM Volume") with a reference to the actual hw mixer element, 
like "PCM Volume (R8,R9)", here example given a reference to the register 
that's actually affected according to WM8753_control_diag.pdf and 
<http://www.wolfsonmicro.com/uploads/documents/WM8753.pdf>,p.77ff R8(08h)*. 
Depending on the length of name allowable, it might be also fine to have the 
full technical name (like "PCM Volume (LDACVOL)", "PCM Volume (RDACVOL)") 
instead of just 1 or 2 digits for Register.
I hope this will contribute to simplify the understanding and handling of the 
mixer.

*) I'm not sure whether even this is the right Reg for PCM Volume, didn't 
exactly check it. So take it as an example.

cheers
jOERG
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://lists.openmoko.org/pipermail/openmoko-devel/attachments/20080610/7a888544/attachment-0001.pgp 


More information about the openmoko-devel mailing list