please merge this patch

[John Lee]

On Fri, Mar 07, 2008 at 02:26:09AM +0100, andrzej zaborowski wrote:
> On 06/03/2008, Rodolphe Ortalo <rodolphe.ortalo at free.fr> wrote:
> > Hello,
> >
> >  make flash-qemu-local fails repeatedly for me (for 4-5 days at least)
> >  while other qemu-related commands apparently work. I tried to have a
> >  look at know problems on the wiki, but apparently they were not really
> >  identical (though similar in some aspects).
> >
> >  Any hint on what the:
> >  qemu: fatal: Trying to execute code outside RAM or ROM at 0x00000000
> >  error line actually means? (Image too big?)
> 
> That could be an image too big ( > 60MB) but isn't in this case.  Qemu
> tracked it down to a memory corruption in latest u-boot.  Attached
> u-boot patch should help (inlined for viewing).
> 
> Shows why it's good to test u-boot images in qemu before flashing them
> to your Neo and bricking it ;)
> 
> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
> @@ -720,7 +720,7 @@ static void process_sequence(char c)
>         switch (c) {
>                 case 'J':
>                         /* assume num1 == 2 */
> -                       memsetl(CONSOLE_ROW_FIRST, CONSOLE_SIZE,
> +                       memsetl(CONSOLE_ROW_FIRST, CONSOLE_SIZE >> 2,
>                             CONSOLE_BG_COL);
>                         break;
>                 case 'H':
> -- 
> Please do not print this email unless absolutely necessary. Spread
> environmental awareness.


Hi Werner,

Could you update console-ansi.patch to reflect this change?  This
indeed fixed the qemu problem.


Regards,
John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-mem-corruption.patch
Type: text/x-diff
Size: 425 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-devel/attachments/20080320/91c6be86/u-boot-mem-corruption.bin