[PATCH] s3c2410 gpio in qemu-neo1973

[Salil Bijur]

Hello,

I noticed the code in qemu-neo1973 to set external interrupts via gpio pins.

switch ((s->extint[e] >> (line * 3)) & 7)
This check assumes that the EINTn register has contiguous sets of 3
bits for signalling method [0-2, 3-5, 6-8, etc].

But I took a look at the user manual of s3c2410 and it seems to be
different. There are sets of 3 bits followed by a reserved bit so the
signalling methods are in bits [0-2, 4-6, 8-10, etc.].
So the correct logic in the switch case should be:
switch ((s->extint[e] >> ((line * 4) - 1)) & 7)

Attaching a patch that hopefully corrects this.

Thanks,
Salil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qemu-gpio-fix.patch
Type: text/x-patch
Size: 912 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-devel/attachments/20080320/33d2cb6e/qemu-gpio-fix.bin