[PATCH] Provide two similar usb device configs with high and low power setting v2

Stefan Schmidt stefan at datenfreihafen.org
Fri Mar 30 15:49:37 CEST 2007


On Fri, 2007-03-30 at 11:37, Harald Welte wrote:
> On Fri, Mar 30, 2007 at 12:19:30AM +0200, Stefan Schmidt wrote:
> > 
> > Enabling RNDIS makes it a bit more tricky. A special order of the
> > configs is needed:
> > 
> > rndis_config
> > eth_config
> > eth_config_low
> > rndis_config_low
> > 
> > Anybody know offhand why this is needed?
> 
> because the host will use the first configuration that "works".  So if
> you have any low_power config before having all high_power configs, then
> the low_power config will be chosen, unless some software/driver
> specifically selects a different one.

Makes sense. But there is still a problem with the fourth config. As
it is rndis_config_low it only appears if using the Neo on a bus
powered hub under windows.

This should be in mind for the person who tests this under windows and
other OSes.

> The same needs to be done for MacOS X at least, too.  

IIRC Koen already used it under MacOSX with RNDIS.

> I think I'll ask roh to look into this once he starts working for
> OpenMoko next week.

Good

> > At the moment this patch applies on top of the current quilt set. I
> > would suggest to remove g_ether-highpower.patch and let this one base
> > on the vanilla g_ether driver once we like to apply this one. If you
> > agree I can take care off it.
> 
> sure, just merge the two patches.

The attached updated patch needs the highpower patch unapplied. If you
are fine with the changes just remove the highpower patch file and the
entry in series and apply this one.

regards
Stefan Schmidt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: two-usb-power-configs.patch
Type: text/x-diff
Size: 5464 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20070330/fae11e48/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 241 bytes
Desc: Digital signature
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20070330/fae11e48/attachment.pgp 


More information about the openmoko-kernel mailing list