[patch 4/6] jbt6k74: Add QVGA support

Harald Welte laforge at openmoko.org
Mon Oct 22 10:49:14 CEST 2007


On Thu, Oct 18, 2007 at 08:10:13PM +0800, Stefan Schmidt wrote:
> Add register init and extend state machine to support QVGA on the LCM.

I'm committing this now, however:

> @@ -367,7 +466,7 @@
>  			     strlen(jbt_state_names[i]))) {
>  			DEBUGP("Switch to state: %i\n", i);
>  			jbt6k74_enter_state(jbt, i);
> -			if (i == JBT_STATE_NORMAL)
> +			if ((i == JBT_STATE_NORMAL)|(i == JBT_STATE_QVGA_NORMAL))
>  				/* Enable display again after deep-standby */
>  				jbt6k74_display_onoff(jbt, 1);
>  			return count;

that one won't work since it uses bit-wise or | rather than logical or ||

I've fixed this and replaced the section by a switch() statement with
fallthrough and default case.

-- 
- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
============================================================================
Software for the world's first truly open Free Software mobile phone




More information about the openmoko-kernel mailing list