[PATCH] nDL_GSM handling (as discussed)

Andy Green andy at openmoko.com
Wed Apr 9 00:41:58 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:

| +			if (on)
| +			    disable_irq(gpio_to_irq(GTA02_GPIO_JACK_INSERT));
| +			else
| +			    enable_irq(gpio_to_irq(GTA02_GPIO_JACK_INSERT));

Holger, great patches you have sent.

This bit above made troubles though -- it can cause "Unbalanced IRQ"
errors depending on what userspace sends down the /sys node, since it
will just go ahead and enable or disable the IRQ without considering the
existing state.

I added a patch on top of this which re-uses the gta01_gsm.gpio_ndl_gsm
state to figure out if it needs to do anything and it stops the warning
and kernel stack trace from the "unbalanced IRQ".

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkf79LAACgkQOjLpvpq7dMpgpwCeO3sc+Js/xutPEZe2lGazi1OO
ZScAoJVXdNEykW3bmCEo17IqCpm4erWq
=OXp1
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-gsm-download-irq-balance-issue.patch
Type: text/x-patch
Size: 2220 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20080408/fa7f6e6a/attachment.bin 


More information about the openmoko-kernel mailing list