[PATCH] nDL_GSM handling (as discussed)

Holger Freyther zecke at openmoko.org
Wed Apr 9 01:56:31 CEST 2008


On Wednesday 09 April 2008 00:41:58 Andy Green wrote:
> Somebody in the thread at some point said:
> | +			if (on)
> | +			    disable_irq(gpio_to_irq(GTA02_GPIO_JACK_INSERT));
> | +			else
> | +			    enable_irq(gpio_to_irq(GTA02_GPIO_JACK_INSERT));
>
> Holger, great patches you have sent.
>
> This bit above made troubles though -- it can cause "Unbalanced IRQ"
> errors depending on what userspace sends down the /sys node, since it
> will just go ahead and enable or disable the IRQ without considering the
> existing state.
>
> I added a patch on top of this which re-uses the gta01_gsm.gpio_ndl_gsm
> state to figure out if it needs to do anything and it stops the warning
> and kernel stack trace from the "unbalanced IRQ".

Sorry and thank you for fixing it.




More information about the openmoko-kernel mailing list