[PATCH 0/7] Updated patchset, Janitor and GPIO GPB/LED work

Holger Freyther zecke at openmoko.org
Thu Apr 10 05:27:27 CEST 2008


Hey,

this is taking Werner's comments into account. This is replacing the first 
round of todays patches and have the notable changes:

Janitor work:
	- OpenMoko => Openmoko renaming of Copyright headers
	- Killing #ifdef CONFIG_MACHINE.. around if (machine_is_ code as
	  machine_is_ is always defined by mach-types.h and the gcc will
	  eliminate dead code (if (0) {}) anyway. This is why I prefer the if
	  checks over the switch() case and would like to update the other
	  drivers as well

Fixes LEDs:
	- Disable the LEDs on removal
	- Initialize num_leds, fix the unused to_bundle (in my mind it is
	  scheduled for removal)
	- #if 0 the PWM init sequence in the probe method for now, we don't
	  need this?

Fixes:
	- Do not poke the bluetooth module when we want to reset the modem
	- Introduce a shadow register for GPB, update all users of the bank b
	  to write through the neo specific gpio code.





More information about the openmoko-kernel mailing list