[PATCH 3/3] fix-stop-sitting-printing-in-time-critical-context.patch

Andy Green andy at openmoko.com
Fri Aug 1 10:00:37 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:

|  		/* track what the time-critical udc callback allows us */
| -		if (pcf50633_usb_last_maxcurrent != udc_usb_maxcurrent)
| -			pcf50633_usb_maxcurrent(udc_usb_maxcurrent);
| +//		if (pcf50633_usb_last_maxcurrent != udc_usb_maxcurrent)
| +//			pcf50633_usb_maxcurrent(udc_usb_maxcurrent);

I uncommented this again in git.

With the last additional patch fix-dont-do-i2c-with-irqs-off.patch I
think this issue is solved for the normal case.

But if the battery is low, we still run the idle loop and destroy USB,
really that is when we can most do with working enumeration so we can
charge.

Werner, what do you feel about binning the idle loop stuff or fixing it
so it doesn't lock out global interrupts how it currently does.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkiSwqUACgkQOjLpvpq7dMqqIACfYsvsLbaS64tMSrizlB3vS8zz
RCMAn1j8fyQ7x+7FfRcNcZqXgUowv/oi
=PXSk
-----END PGP SIGNATURE-----




More information about the openmoko-kernel mailing list