[PATCH] set-the-eint-configuration-correctly.patch

[Ben Dooks]

On Fri, Nov 28, 2008 at 08:58:24PM +0800, matt_hsu wrote:
> Fix the eint type configuration for s3c64xx.
> 
> Matt

> From: Matt Hsu <matt_hsu at openmoko.org>
> Date: Fri, 28 Nov 2008 21:16:01 +0800
> 
> set the eint configuration correctly
> 
> Signed-off-by: Matt Hsu <matt_hsu at openmoko.org>

In future, please just inline the patch, the description should say
enough about what the patch does to ensure we don't need any precis
to say it again. It makes life easier when passing to 'git am'.

Another commet would be to make the Subject line of the email be a
short explanation of the patch, an example of a good Subject line is
shown below:

	"S3C64XX: Correct the EINT IRQ type configuration"

It is useful to prefix the message with the architecture or cpu that
is being applied to, so in this case 'S3C64XX:'.

> ---
>  arch/arm/plat-s3c64xx/irq-eint.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-s3c64xx/irq-eint.c b/arch/arm/plat-s3c64xx/irq-eint.c
> index 24c5e89..87a43a0 100644
> --- a/arch/arm/plat-s3c64xx/irq-eint.c
> +++ b/arch/arm/plat-s3c64xx/irq-eint.c
> @@ -82,7 +82,7 @@ static int s3c_irq_eint_set_type(unsigned int irq, unsigned int type)
>  	if (offs > 27)
>  		return -EINVAL;
>  
> -	if (offs > 15)
> +	if (offs < 15)
>  		reg = S3C64XX_EINT0CON0;
>  	else
>  		reg = S3C64XX_EINT0CON1;
> -- 
> 1.5.5.1

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.