[PATCH] Filter key bouncing for more keys

Michael Buesch mb at bu3sch.de
Tue Dec 30 23:58:26 CET 2008


On Tuesday 30 December 2008 23:38:35 Nelson Castillo wrote:
> > +               if (irq == keys[n].irq) {
> > +                       if (machine_is_neo1973_gta01() && global_inside_suspend
> > +                           && NEO1973_KEY_AUX == n) {
> > +                               /* if you stall inside resume then AUX will
> > +                                * force a panic, which in turn forces a dump
> > +                                * of the pending syslog */
> > +                               int *p = NULL;
> > +                               printk(KERN_ERR "death %d\n", *p);

Why not like this?
I think this has a better chance of getting accepted upstream.

	dump_stack();
	panic("AUX stall inside resume\n");

-- 
Greetings, Michael.



More information about the openmoko-kernel mailing list