[PATCH Try#2] introduce-fiq-hdq.patch

Werner Almesberger werner at openmoko.org
Wed Feb 13 00:02:37 CET 2008


Andy Green wrote:
> introduce-fiq-hdq.patch

Thanks ! Checked into revision 4052. Two nitpicks:

- return (doesn't need parentheses);

- incremental patches are slightly safer than a re-issue of an
  older patch (of course, as long as I have a copy of the old one
  and interdiff gets it right, that works as well)

There's one change that's problematic in the light of recent
discussion:

-MODULE_DESCRIPTION("FIC Neo1973 GTA02 HDQ driver");
+MODULE_DESCRIPTION("Neo Freerunner HDQ driver");

That's the "marketing name". In order to avoid getting burned again,
this should be either GTA02 or maybe OpenMoko GTA02. I've tentatively
changed it to GTA02 in revision 4053.

- Werner




More information about the openmoko-kernel mailing list