[PATCH Try#2] introduce-fiq-hdq.patch

Andy Green andy at openmoko.com
Thu Feb 14 10:37:30 CET 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
> On Wednesday 13 February 2008 10:15:25 Andy Green wrote:
>> Somebody in the thread at some point said:
>>> On Wednesday 13 February 2008 10:01:42 Andy Green wrote:
>>>> Somebody in the thread at some point said:
>>>>>> There's one change that's problematic in the light of recent
>>>>>> discussion:
>>>>>>
>>>>>> -MODULE_DESCRIPTION("FIC Neo1973 GTA02 HDQ driver");
>>>>>> +MODULE_DESCRIPTION("Neo Freerunner HDQ driver");
>>>>>>
>>>>>> That's the "marketing name". In order to avoid getting burned again,
>>>>>> this should be either GTA02 or maybe OpenMoko GTA02.
>>>>> I agree. Please lets stick with GTA02 in source code.
>>>> Can you explain why?  For MODULE_DESCRIPTION?
>>> For everything that's not user-visible. The machine database entry is:
>> MODULE_DESCRIPTION is user-visible...
>>
>> # modinfo blah
> 
> Err, well. I was more thinking UI user ;)

Hi Mickey -

Maybe you can help explain another branding anomoly since it seems you
have a system in mind.

The Kconfig I made for HDQ and bq27000 drivers uses the branding names,
which makes sense to me, and this was accepted.  Can you articulate how
that situation differed from the MODULE_DESCRIPTION case?  Or you think
we should use GTA02 there?  If not, why not?

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHtAvaOjLpvpq7dMoRAoCvAJ9rl4JdDtFzBcmknKucwgXjS7iQfwCgiv1l
Ko1MECs6NJwM9nseW6VlRDM=
=mlwF
-----END PGP SIGNATURE-----




More information about the openmoko-kernel mailing list