[PATCH] fix-glamo-reissue-memory-settings-during-resume.patch
Andy Green
andy at openmoko.com
Tue Mar 25 10:00:39 CET 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Somebody in the thread at some point said:
> Are the changes below also related to the black snow ?
>
>> static struct glamo_script glamo_init_script[] = {
>> { GLAMO_REG_CLOCK_HOST, 0x1000 },
>> - { 0xfffe, 1 },
>> + { 0xfffe, 2 },
Increase delay because I changed it from msleep -> mdelay for the path
used in resume.
>> { GLAMO_REG_CLOCK_MEMORY, 0x1000 },
>> { GLAMO_REG_CLOCK_MEMORY, 0x2000 },
>> { GLAMO_REG_CLOCK_LCD, 0x1000 },
>> @@ -638,8 +650,8 @@ static struct glamo_script glamo_init_script[] = {
>> { GLAMO_REG_CLOCK_RISC1, 0x1000 },
>> { GLAMO_REG_CLOCK_MPEG, 0x3000 },
>> { GLAMO_REG_CLOCK_MPEG, 0x3000 },
>> - { GLAMO_REG_CLOCK_MPROC, 0x100f },
>> - { 0xfffe, 1 },
>> + { GLAMO_REG_CLOCK_MPROC, 0x1000 /*0x100f*/ },
>> + { 0xfffe, 2 },
Force reset on that MPU, kill clocks to it, increase delay same reason
as above.
>> #endif
>> - { GLAMO_REG_CLOCK_MPROC, 0x000f },
>> - { 0xfffe, 1 },
We don't use this Glamo CPU, I leave it in reset now so it can't
contribute to RAM bandwidth starvation.
>> - { 0xfffe, 50 },
>> + { 0xfffd, 0 },
Forces a spin on PLL sync rather than random long wait.
> I already had the following hunk:
>
>> @@ -676,13 +686,9 @@ static struct glamo_script glamo_init_script[] = {
>> { 0x212, 0x0000 },
It's a reversion of something you never had I think.
> And I also had this bit:
>
>> @@ -791,10 +837,10 @@ static void glamo_power(struct glamo_core *glamo,
>> GLAMO_MEM_DRAM2_DEEP_PWRDOWN, 0x0000);
>> __reg_set_bit_mask(glamo, GLAMO_REG_MEM_DRAM1,
>> GLAMO_MEM_DRAM1_SELF_REFRESH, 0x0000);
>> - /* FIXME: reset pll's */
>> - /* spin until PLL1 lock */
>> - while (!(__reg_read(glamo, GLAMO_REG_PLL_GEN5) & 1))
>> - ;
>
> ... except for the removal of "/* FIXME: reset pll's */".
Same again, in fact the PLL spin is moved just above this and spins on
both PLLs now. There is no "reset pll" concept in the Glamo.
- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFH6L83OjLpvpq7dMoRAmj1AJ9oNp7IAZN0bRVEPXqITLMr023xqgCfVQuV
62Bwxzl0q7zGcIRsY1qeqaU=
=/+oG
-----END PGP SIGNATURE-----
More information about the openmoko-kernel
mailing list