[PATCH] Disable low level debugging, make the s3c24xx PM debug code depend on DEBUG_LL

Mike (mwester) mwester at dls.net
Tue May 27 22:40:59 CEST 2008


We need the equivalent patch applied for the GTA01, please.  In the case of the 
GTA01, this stuff is spewed directly into the GSM upon wakeup, which has an 
unfortunate tendency to confuse both GSM and gmsd simultaneously.

Patch attached.

Thanks,
Mike


Holger Freyther wrote:
> Hey,
> where are slowly getting into the product state, low level debugging is 
> supposed to be turned off there. :)
> 
> z
> 
> 
> 
> From 6448f0a521c05c5ba6672f5908c55583974ce1ed Mon Sep 17 00:00:00 2001
> From: Holger Freyther <zecke at openmoko.org>
> Date: Fri, 9 May 2008 19:56:31 +0200
> Subject: [PATCH] [debug] Disable low level debugging for the product
>      Disable low level debugging in the defconfig-gta02 and
>      the s3c pm code used printascii which is only available
>      with low level debugging, update the Kconfig entry for
>      this pm debugging support to depend on low level debugging
> 
> Signed-Off-By: Holger Freyther <zecke at openmoko.org>
> ---
>  arch/arm/plat-s3c/Kconfig |    2 +-
>  defconfig-gta02           |    5 +----
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/plat-s3c/Kconfig b/arch/arm/plat-s3c/Kconfig
> index 31656c3..73bbff3 100644
> --- a/arch/arm/plat-s3c/Kconfig
> +++ b/arch/arm/plat-s3c/Kconfig
> @@ -61,7 +61,7 @@ comment "Power management"
>  
>  config S3C2410_PM_DEBUG
>  	bool "S3C2410 PM Suspend debug"
> -	depends on PLAT_S3C && PM
> +	depends on PLAT_S3C && PM && DEBUG_LL
>  	help
>  	  Say Y here if you want verbose debugging from the PM Suspend and
>  	  Resume code. See <file:Documentation/arm/Samsung-S3C24XX/Suspend.txt>
> diff --git a/defconfig-gta02 b/defconfig-gta02
> index 00ca091..68cf1f4 100644
> --- a/defconfig-gta02
> +++ b/defconfig-gta02
> @@ -159,7 +159,6 @@ CONFIG_CPU_LLSERIAL_S3C2440=y
>  #
>  # Power management
>  #
> -CONFIG_S3C2410_PM_DEBUG=y
>  # CONFIG_S3C2410_PM_CHECK is not set
>  CONFIG_S3C_LOWLEVEL_UART_PORT=2
>  
> @@ -1693,9 +1692,7 @@ CONFIG_FORCED_INLINING=y
>  # CONFIG_SAMPLES is not set
>  # CONFIG_DEBUG_USER is not set
>  CONFIG_DEBUG_ERRORS=y
> -CONFIG_DEBUG_LL=y
> -# CONFIG_DEBUG_ICEDCC is not set
> -CONFIG_DEBUG_S3C_PORT=y
> +# CONFIG_DEBUG_LL is not set
>  CONFIG_DEBUG_S3C_UART=2
>  
>  #
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gta01_config_no_pmdebug.patch
Url: http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20080527/284ea531/attachment.txt 


More information about the openmoko-kernel mailing list