[PATCH 1/2] I2C: Convert PCF50606 to I2C device

Jonas Bonn jonas.bonn at gmail.com
Fri Oct 3 13:49:13 CEST 2008


>> -/* We have this purely to capture an early indication that we are coming out
>> - * of suspend, before our device resume got called; async interrupt service is
>> - * interested in this.
>> - */
>> -
>> -static int pcf50606_plat_resume(struct platform_device *pdev)
>> -{
>> -     /* i2c_get_clientdata(to_i2c_client(&pdev->dev)) returns NULL at this
>> -      * early resume time so we have to use pcf50606_global
>> -      */
>> -     pcf50606_global->suspend_state = PCF50606_SS_RESUMING_BUT_NOT_US_YET;
>> -
>> -     return 0;
>> -}
>
> Dunno about 50606 but I think the equivalent was important on 50633
> resume sequencing.  Did you confirm it suspend / resumes OK still?

Suspend/resume works but I did confirm that suspend/resume becomes a
bit buggy with this patch... :)

This is the only bit that does not fit with the transition to a pure
I2C model.  Any tips on where this should go?

/Jonas



More information about the openmoko-kernel mailing list