[UPSTREAM] Attempt at improving ADC access

Balaji Rao balajirrao at openmoko.org
Thu Oct 16 11:31:42 CEST 2008


On Thu, Oct 16, 2008 at 06:31:47AM -0200, Werner Almesberger wrote:
> Balaji Rao wrote:
> > Ah, now I remember! From the proposed sync callback, we wouldn't know
> > which completion to complete as we wouldn't be passed the adc_request
> > object. We could very well look at the queue head, but that would not be
> > a clean way to do it. What do you say ?
> 
> How about passing the request ? Or a void pointer that's passed to
> the callback function, which then does with it whatever it wants,
> i.e., the usual
> 
> 	..., void (*fn)(void *arg), void *arg, ...
> 
> idiom.

Werner,

I tried this one as well but had dropped it in favour of a clean
interface.

But now I'm thinking it might be needed by async read functions as well
to store some kind of context. I'll go ahead and do this.

Thank you,

	- Balaji



More information about the openmoko-kernel mailing list