[PATCH 4/8] improve-style-neo1973_pm_gps.patch
Nelson Castillo
nelsoneci at gmail.com
Thu Oct 16 19:00:56 CEST 2008
- Improve style.
- Fixed a typo (Managerment => Management).
Signed-off-by: Nelson Castillo <nelsoneci at gmail.com>
---
0 files changed, 0 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-s3c24xx/neo1973_pm_gps.c b/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
index 6fabf19..cf712e6 100644
--- a/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
+++ b/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
@@ -1,7 +1,7 @@
/*
- * GPS Power Management code for the FIC Neo1973 GSM Phone
+ * GPS Power Management code for the Openmoko GTA01/GTA02 GSM Phone
*
- * (C) 2007 by Openmoko Inc.
+ * (C) 2007-2008 by Openmoko Inc.
* Author: Harald Welte <laforge at openmoko.org>
* All rights reserved.
*
@@ -75,7 +75,7 @@ static int gps_power_2v8_get(void)
case GTA01v3_SYSTEM_REV:
case GTA01v4_SYSTEM_REV:
if (pcf50606_onoff_get(pcf50606_global,
- PCF50606_REGULATOR_IOREG) &&
+ PCF50606_REGULATOR_IOREG) &&
pcf50606_voltage_get(pcf50606_global,
PCF50606_REGULATOR_IOREG) == 2800)
ret = 1;
@@ -281,7 +281,7 @@ static void gps_pwron_set(int on)
if (machine_is_neo1973_gta02()) {
if (on) {
pcf50633_voltage_set(pcf50633_global,
- PCF50633_REGULATOR_LDO5, 3000);
+ PCF50633_REGULATOR_LDO5, 3000);
/* return UART pins to being UART pins */
s3c2410_gpio_cfgpin(S3C2410_GPH4, S3C2410_GPH4_TXD1);
/* remove pulldown now it won't be floating any more */
@@ -297,7 +297,7 @@ static void gps_pwron_set(int on)
s3c2410_gpio_pullup(S3C2410_GPH5, 1);
}
pcf50633_onoff_set(pcf50633_global,
- PCF50633_REGULATOR_LDO5, on);
+ PCF50633_REGULATOR_LDO5, on);
}
}
@@ -308,7 +308,7 @@ static int gps_pwron_get(void)
if (machine_is_neo1973_gta02())
return !!pcf50633_onoff_get(pcf50633_global,
- PCF50633_REGULATOR_LDO5);
+ PCF50633_REGULATOR_LDO5);
return -1;
}
@@ -444,7 +444,7 @@ static void gps_power_sequence_up(void)
* shared with RFREG_IN */
gps_power_3v_set(1);
- msleep(3); /* Is 3ms enough? */
+ msleep(3); /* Is 3ms enough? */
/* De-asert nRESET */
gps_rst_set(1);
@@ -487,12 +487,15 @@ static ssize_t power_sequence_write(struct device *dev,
{
dev_dbg(dev, "wrote: '%s'\n", buf);
- if (!strncmp(buf, "power_up", 8))
+ if (!strncmp(buf, "power_up", 8)) {
gps_power_sequence_up();
- else if (!strncmp(buf, "power_down", 10))
+ }
+ else if (!strncmp(buf, "power_down", 10)) {
gps_power_sequence_down();
- else
+ }
+ else {
return -EINVAL;
+ }
return count;
}
@@ -532,7 +535,7 @@ static int gta01_pm_gps_resume(struct platform_device *pdev)
#endif
if (machine_is_neo1973_gta02())
if (neo1973_gps.power_was_on)
- gps_pwron_set(1);
+ gps_pwron_set(1);
return 0;
}
@@ -555,7 +558,7 @@ static struct attribute *gta01_gps_sysfs_entries[] = {
NULL, /* power_core_1v5 */
NULL, /* power_vdd_core_1v5 */
#endif
- NULL /* terminating entry */
+ NULL /* terminating entry */
};
static struct attribute_group gta01_gps_attr_group = {
@@ -582,21 +585,26 @@ static int __init gta01_pm_gps_probe(struct platform_device *pdev)
case GTA01v3_SYSTEM_REV:
break;
case GTA01v4_SYSTEM_REV:
- s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_RESET, S3C2410_GPIO_OUTPUT);
+ s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_RESET,
+ S3C2410_GPIO_OUTPUT);
break;
case GTA01Bv3_SYSTEM_REV:
case GTA01Bv4_SYSTEM_REV:
- s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_EN_3V3, S3C2410_GPIO_OUTPUT);
+ s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_EN_3V3,
+ S3C2410_GPIO_OUTPUT);
/* fallthrough */
case GTA01Bv2_SYSTEM_REV:
- s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_EN_2V8, S3C2410_GPIO_OUTPUT);
- s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_EN_3V, S3C2410_GPIO_OUTPUT);
- s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_RESET, S3C2410_GPIO_OUTPUT);
+ s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_EN_2V8,
+ S3C2410_GPIO_OUTPUT);
+ s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_EN_3V,
+ S3C2410_GPIO_OUTPUT);
+ s3c2410_gpio_cfgpin(GTA01_GPIO_GPS_RESET,
+ S3C2410_GPIO_OUTPUT);
break;
default:
dev_warn(&pdev->dev, "Unknown GTA01 Revision 0x%x, "
- "AGPS PM features not available!!!\n",
- system_rev);
+ "AGPS PM features not available!!!\n",
+ system_rev);
return -1;
break;
}
@@ -620,7 +628,8 @@ static int __init gta01_pm_gps_probe(struct platform_device *pdev)
break;
}
#endif
- return sysfs_create_group(&pdev->dev.kobj, >a01_gps_attr_group);
+ return sysfs_create_group(&pdev->dev.kobj,
+ >a01_gps_attr_group);
}
if (machine_is_neo1973_gta02()) {
@@ -631,16 +640,17 @@ static int __init gta01_pm_gps_probe(struct platform_device *pdev)
case GTA02v5_SYSTEM_REV:
case GTA02v6_SYSTEM_REV:
pcf50633_voltage_set(pcf50633_global,
- PCF50633_REGULATOR_LDO5, 3000);
+ PCF50633_REGULATOR_LDO5, 3000);
pcf50633_onoff_set(pcf50633_global,
- PCF50633_REGULATOR_LDO5, 0);
- dev_info(&pdev->dev, "FIC Neo1973 GPS Power Managerment:"
+ PCF50633_REGULATOR_LDO5, 0);
+ dev_info(&pdev->dev,
+ "FIC Neo1973 GPS Power Management:"
"starting\n");
break;
default:
dev_warn(&pdev->dev, "Unknown GTA02 Revision 0x%x, "
- "AGPS PM features not available!!!\n",
- system_rev);
+ "AGPS PM features not available!!!\n",
+ system_rev);
return -1;
break;
}
@@ -690,4 +700,4 @@ module_exit(gta01_pm_gps_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Harald Welte <laforge at openmoko.org>");
-MODULE_DESCRIPTION("FIC Neo1973 GPS Power Management");
+MODULE_DESCRIPTION("Openmoko GTA01/GTA02 GPS Power Management");
More information about the openmoko-kernel
mailing list