[UPSTREAM PATCH] pm_gps_use_regulator_api.patch

Werner Almesberger werner at openmoko.org
Wed Oct 29 19:54:00 CET 2008


Balaji Rao wrote:
> +		if ((on) && (!neo1973_gps.power_was_on))
> +			regulator_enable(neo1973_gps.regulator);
> +
> +		if ((!on) && (neo1973_gps.power_was_on))
> +			regulator_disable(neo1973_gps.regulator);

They won't change operator precedence in GCC anytime soon :-)
Doesn't this look a lot less intimidating ?

> +		if (on && !neo1973_gps.power_was_on)
...
> +		if (!on && neo1973_gps.power_was_on)

- Werner



More information about the openmoko-kernel mailing list