[PATCH] gta03-pca9632.patch

matt_hsu matt_hsu at openmoko.org
Mon Sep 15 15:15:52 CEST 2008


matt_hsu wrote:
Hi Andy,

Please ignore the previous patch.

Cheers,
Matt
> michael wrote:
>   
>> Hi,
>>
>> matt_hsu wrote:
>>   
>>     
>>> michael wrote:
>>>     
>>>       
>>>> Hi,
>>>> matt_hsu wrote:
>>>>   
>>>>       
>>>>         
>>>>> pca9632 is a LED driver in gta03.
>>>>> This patch patch adds the support for this chip.
>>>>>
>>>>> Matt
>>>>>     
>>>>>         
>>>>>           
>>>> +static int pca9632_detach_client(struct i2c_client *client)
>>>> +{
>>>> + int err;
>>>> +
>>>> + sysfs_remove_group(&client->dev.kobj, &pca_attr_group);
>>>> +
>>>> + if ((err == i2c_detach_client(client)))
>>>>
>>>> + return err;
>>>>
>>>> Err is non initialized and then is compared with detach_client
>>>>
>>>>   
>>>>       
>>>>         
>>> Well, I know it creates a compile warning with non-initialized variable.
>>> Since there are something on my TODO list specific to this driver.
>>> I'll correct this in the next coming patch.
>>>
>>>     
>>>       
>> I don't understand :). err is initializated and the in the *if* you use it
>> for a test?
>>   
>>     
> Ha, it's a stupid typing mistake. It should look like
>
> 	if ((err = i2c_detach_client(client)))
>
> 	It should be an assignment in the if condition.
> 	Matt
>
>   
>>> Matt
>>>     
>>>       
>>>> :)
>>>>
>>>> Michael
>>>>   
>>>>       
>>>>         
>>>   
>>>     
>>>       
>> Michael
>>
>>
>>   
>>     
>
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gta03-pca9632.patch
Type: text/x-patch
Size: 16081 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20080915/66298e72/attachment.bin 


More information about the openmoko-kernel mailing list