[PATCH] gta03-pca9632.patch (#2 submit)

michael trimarchi at gandalf.sssup.it
Thu Sep 18 12:48:41 CEST 2008


Andy Green wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Somebody in the thread at some point said:
> | hi,
> |
> | just a comment:) (I hope it is correct)
> |
> | Say that platform data are not copied and so you can't put it in
> | the initdata section.
>
> Not sure I understood this, the patch just provides the driver and does
> not create platform data instance, in initdata or elsewhere?  It's OK if
> we can't put any platform data in initdata because we use it directly,
> we do that in other drivers already.
>
You are right,

/* FIXME: platform data should be attached here */
+ pca9632_pdev = pdev
I was thinking about this note and maybe add few comments.

I'm sorry :(

Regards Michael

> If I missed the point please explain a bit more.
>
> - -Andy
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iEYEARECAAYFAkjSKa0ACgkQOjLpvpq7dMqLFQCfVkzG8J2l12CHTR9670diTHVS
> c4IAn1iSBS81XJiaC14+guc80pYG9keQ
> =qDSE
> -----END PGP SIGNATURE-----
>




More information about the openmoko-kernel mailing list