[PATCH 5/7] fix-wrongful-led-trigger-removal.patch

Andy Green andy at openmoko.com
Tue Sep 23 01:17:40 CEST 2008


From: Sean McNeil <sean at mcneil.com>

LED trigger gets removed in led_brightness_store???

Signed-off-by: Sean McNeil <sean at mcneil.com>
---

 drivers/leds/led-class.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 559a408..e8350e3 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -59,8 +59,10 @@ static ssize_t led_brightness_store(struct device *dev,
 	if (count == size) {
 		ret = count;
 
+#if 0 /* This is really bad. Don't do it!!!! */
 		if (state == LED_OFF)
 			led_trigger_remove(led_cdev);
+#endif
 		led_set_brightness(led_cdev, state);
 	}
 




More information about the openmoko-kernel mailing list