[PATCH] ASoC: Clean up coding style issues in GTA02
Werner Almesberger
werner at openmoko.org
Fri Apr 3 18:30:53 CEST 2009
Mark Brown wrote:
> I think you're reading the patch the wrong way round :)
Am I ? Before:
| if(val) {
| lm4853_state |= LM4853_AMP;
| } else {
| lm4853_state &= ~LM4853_AMP;
| }
after
| if (val)
| lm4853_state |= LM4853_AMP;
| else
| lm4853_state &= ~LM4853_AMP;
yet line 172 of Documentation/CodingStyle says
| Use braces in both branches.
I agree with you preferring the style used in your patch, but I
wonder how to resolve the apparent disagree with CodingStyle.
K&R 2nd ed. also seems to agree with us and even condones braceless
single-statement else, e.g., on page 125.
- Werner
More information about the openmoko-kernel
mailing list