[PATCH] U-Boot GTA02: Always enable charger on startup

Werner Almesberger werner at openmoko.org
Wed Aug 26 16:44:53 CEST 2009

Rask Ingemann Lambertsen wrote:
>    No, but I did now and it works.

Kewl !

>    So as to try booting with only 100 mA external power available and no
> battery? I suppose wait_for_power() expects to be called with the charger
> disabled, but it can be changed to do that itself.

Yes, what I observed was that the battery voltage climbed almost
immediately to Vsys (there are a few caps in the way that slow
this down, but it doesn't take long to charge them), and then
wait_for_power thinks it sees a healthy battery.

>> Hmm, what does this change accomplish ?
>    The first hunk ensures that we exit wait_for_power() with the charger
> enabled. The second hunk removes a piece of code that is now a no op because
> the charger is already enabled at that point.

Yes, but isn't that basically what happened before as well, just a
few milliseconds later ? My question is if there was anything subtly
wrong in the functionality or if you just changed it for esthetics.

- Werner

More information about the openmoko-kernel mailing list