[PATCH 7/8] qi-add-gta02-indentity-part-parsing.patch

Werner Almesberger werner at openmoko.org
Fri Feb 20 03:29:42 CET 2009


Robert Piasek wrote:
>  	cmdline += strlen(strcpy(cmdline, &mac[2]));
>  	*cmdline += ' ' ;

Hmm, shouldn't that be

	*cmdline++ = ' ';

?

> +	cmdline += strlen(strcpy(cmdline, " g_ether.dev_addr="));

Then you don't need the leading space.

> +	cmdline += strlen(strcpy(cmdline, &mac[2]));

And you should increment the MAC address. Having the same MAC
on both ends is weird and may trip something.

- Werner



More information about the openmoko-kernel mailing list