[PATCH] fix-pm-gsm-disable-serial-drive-when-off.patch

Werner Almesberger werner at openmoko.org
Sun Feb 22 15:26:19 CET 2009


Andy Green wrote:
> Since several people worked on this area before, and maybe the
> assertion of GSM OFF is different (it's OFF from bootloader though)
> or maybe something else gets broken, I send the patch for comment
> before applying it.

Thanks ! At first glance, it looks good. I'll give it a closer look
tomorrow.

> +	s3c2410_gpio_cfgpin(S3C2410_GPH1, S3C2410_GPH1_OUTP);
> +	msleep(1000);
> +	s3c2410_gpio_cfgpin(S3C2410_GPH1, S3C2410_GPH1_nRTS0);

Do we really have to wait a whole second ? Perhaps Dieter can help
us with this question.

BTW, it's amazing how much junk disappears thanks to unsupporting
v1/v2.

- Werner



More information about the openmoko-kernel mailing list