[PATCH] fix-pm-gsm-disable-serial-drive-when-off.patch

Andy Green andy at openmoko.com
Tue Feb 24 02:53:01 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
| On Sun, Feb 22, 2009 at 06:48:16AM +0000, Andy Green wrote:
|
|> Second, when GSM is OFF, it changes the RTS and TXD pins on
|> UART 0 to be inputs, instead of driving into a dead subsystem
|> and costing us ~70mA @ 5V constant dissipation (these 3.3V pins
|> were found at 1.5V due to that).
|
|    Just wondering: Do we have the same problem with the GPS port?

It's a good thought, but it looks like somebody (from the comments,
myself) took care of it:

	if (machine_is_neo1973_gta02()) {
		if (on) {
			/* return UART pins to being UART pins */
			s3c2410_gpio_cfgpin(S3C2410_GPH4, S3C2410_GPH4_TXD1);
			/* remove pulldown now it won't be floating any more */
			s3c2410_gpio_pullup(S3C2410_GPH5, 0);
		} else {
			/*
			 * take care not to power unpowered GPS from UART TX
			 * return them to GPIO and force low
			 */
			s3c2410_gpio_cfgpin(S3C2410_GPH4, S3C2410_GPH4_OUTP);
			s3c2410_gpio_setpin(S3C2410_GPH4, 0);
			/* don't let RX from unpowered GPS float */
			s3c2410_gpio_pullup(S3C2410_GPH5, 1);
		}
- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkmjUv0ACgkQOjLpvpq7dMrogwCgka7hF3Gmi1O9FFcaOA61/hCd
aPAAoIA0bVYxFxQZ8ECG+9F9iWdIVRtD
=qV4c
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list