[PATCH 1/2] Remove unneeded concurrency check (s3c2410_ts.c)

Nelson arhuaco at freaks-unidos.net
Tue Jan 6 10:58:01 CET 2009


From: Nelson Castillo <arhuaco at freaks-unidos.net>

This code was needed before but now it is not useful.

event_send_timer_f is not called directly now thus
the concurrency check is not needed. Remove it.
We only schedule the timer using mod_timer.

Signed-off-by: Nelson Castillo <arhuaco at freaks-unidos.net>
---

 0 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
index bc9b410..46a33df 100644
--- a/drivers/input/touchscreen/s3c2410_ts.c
+++ b/drivers/input/touchscreen/s3c2410_ts.c
@@ -190,16 +190,9 @@ static struct timer_list event_send_timer =
 
 static void event_send_timer_f(unsigned long data)
 {
-	static unsigned long running;
 	static int noop_counter;
 	int event_type;
 
-	if (unlikely(test_and_set_bit(0, &running))) {
-		mod_timer(&event_send_timer,
-			  jiffies + TS_RELEASE_TIMEOUT);
-		return;
-	}
-
 	while (__kfifo_get(ts.event_fifo, (unsigned char *)&event_type,
 			   sizeof(int))) {
 		int buf[2];
@@ -253,8 +246,6 @@ static void event_send_timer_f(unsigned long data)
 		mod_timer(&event_send_timer, jiffies + TS_RELEASE_TIMEOUT);
 	}
 
-	clear_bit(0, &running);
-
 	return;
 
 ts_exit_error: /* should not happen unless we have a bug */




More information about the openmoko-kernel mailing list