[PATCH 0/8] QI: make phase2.c easier to change

Andy Green andy at openmoko.com
Fri Jan 9 05:40:44 CET 2009

Hash: SHA1

Somebody in the thread at some point said:
| Somebody in the thread at some point said:
| | Andy Green wrote:
| |> Sorry, could you explain why we want to add support for zImages?
| |
| | I can think of two reasons:
| |
| | - the kexec compatibility issue Petr Vanek has pointed out in
| |   the "Touch based Dual Boot Menu" thread (see my reply there)
| |
| | - zImages don't have an external dependency on tools/mkimage,
| |   eliminating the last remnants of u-boot's evil rule :-)
| Hm after completely wasting last night on a thread where people --
| including you -- come out of the woodwork to explain the value of
| talking to upstream before doing any work, maybe we should have had the
| larger discussion here first.
| In the thread you mention, you point out that pivot_root will do in the
| shared kernel case and then kexec and zImage is not needed.
| Since 9 of those 11 patches are just whitespace / breaking out existing
| working code into the same code in subfunctions, and "supporting zImage"
| in patch 3/3 is a very small and simple piece of additional code mainly
| checking a magic I guess they're fine anyway.

Thanks I put it on master.

FYI your quilt is misconfigured and the "From: " field needs changing to
the Name <email> form, the import is rejected on it.  I did these ones
by hand.

I don't know if it's unreasonable given how the patches are made ad-hoc,
but it would be perfectly fine to just issue just one "clean-" type
patch with breakout / whitespace changes that you can be pretty sure are
not objectionable.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list