[PATCH] pcf50633 IRQ handler

Michael Trimarchi trimarchi at gandalf.sssup.it
Wed Jan 14 12:20:46 CET 2009


Andy Green wrote:
> Hash: SHA1
> Somebody in the thread at some point said:
> | What do you think about the attached patch?
> Michael AUX button on corner is not a supported wake source, due to
> hardware problems it cannot wake the device reliably anyway.
> Instead for now it is used as a probe for failed resume.  If we are
> inside a suspend -resume and you press AUX (recall it is not a valid
> wake source) then it will force a panic and dump pending syslog and a
> backtrace of wherever we were stuck.
The patch fix the issue. The problem is different. When the system go to 
what is the global_inside_suspend? The irq can arrive in the middle. The 
is setted before go to suspend I think, so It can raise an excepetion. 
Can you comment the patch?
> So if you are trying to wake by AUX, that's definitely bad idea for
> those two reasons.

More information about the openmoko-kernel mailing list