Kernel doesn't compile without CONFIG_SERIAL_SAMSUNG set

Sven 'sleipnir' Rebhan odinshorse at
Wed Jan 14 22:21:58 CET 2009

Hello everybody,

by not setting CONFIG_SERIAL_SAMSUNG the option
CONFIG_SERIAL_SAMSUNG_UARTS does not get declared and thus the build
of the kernel fails with:

    CC      arch/arm/plat-s3c/init.o
    arch/arm/plat-s3c/init.c:94: error: 'CONFIG_SERIAL_SAMSUNG_UARTS'
undeclared here (not in a function)

where arch/arm/plat-s3c/init.c:94 is:

    static struct s3c2410_uartcfg uart_cfgs[CONFIG_SERIAL_SAMSUNG_UARTS];

IMO there are two possible ways of fixing this. The first is to always
force CONFIG_SERIAL_SAMSUNG on CONFIG_PLAT_S3C and the second is to
only initialize the uarts if the said option is set. What would be the
right way?

Best regards,


More information about the openmoko-kernel mailing list