[PATCH 2/3] Move touchscreen filter includes

Andy Green andy at openmoko.com
Sat Jan 17 13:35:45 CET 2009

Hash: SHA1

Werner Almesberger wrote:
> Nelson Castillo wrote:
>> I'm sending a patch that does both things.
> Thanks !
> Mixing moves with small changes always leaves some uneasiness.
> Actually moves generally do, whether there are changes or not. This
> is because nobody is going to verify if you really just moved the
> file or if you also changed it, possibly by accident.
> It's a bit of a pity that, while you seem to use git as well, the
> submissions from you to Andy are still by mailing patches instead of

Nelson what you're doing is fine as it is.

I was going to write about this experience with touchscreen drivers and
upstream later since it seems there are some lessons for us here.

Every bad word about the touchscreen code in kernel concept so far has
come from people with openmoko email addresses, despite that code fixes
something critical on our device.  tslib and input lists did not have
anything to say, and the code is currently getting reviewed by Andrew
Morton direct on lkml.  It's not insane that if we bring it to his
standards, we might get in his branch since he bothers to line-by-line it.

So for all the "advice", the only thing that moved this on either for
working touchscreen on our device, or getting it towards upstream (it
can still fail, but it starts very well), was conceiving, writing,
ignoring the doomsayers and then presenting and improving the code on lkml.

The enemy quite often seems to be us.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list