[PATCH] Attach TPO LPJ028T LCM(L1K002) driver to the gta03.

Andy Green andy at openmoko.com
Tue Jan 20 15:26:17 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:

| +static void gta03_l1k002_pwronoff(int level)
| +{
| +	gpio_direction_output(GTA03_GPIO_LCM_SD, 1);
| +	mdelay(10);
| +	gpio_direction_output(GTA03_GPIO_LCM_RESET, 1);
| +	mdelay(15);
| +	gpio_direction_output(GTA03_GPIO_LCM_SD, 0);
| +}

Do we need this big delays?

The code doesn't seem to refer to "level" either.

I sent it on andy-tracking anyway.

Also what of pca9632 now we aren't using it any more... we should either
pull it out or fix this warning...

/projects/openmoko/kernel/linux-2.6/drivers/i2c/chips/pca9632.c: In
function ‘software_rst’:

/projects/openmoko/kernel/linux-2.6/drivers/i2c/chips/pca9632.c:132:
warning: initialization from incompatible pointer type

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkl13vEACgkQOjLpvpq7dMpvLgCeOIKrhBaUN7tT3XwXtlFgE7VL
8tcAn3jO9+wCiNwGRrJv4B2YLbvIAY4u
=b2Gs
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list