[ANDROID KERNEL PATCH 5/7] Update Kernel core files

Michael Trimarchi trimarchi at gandalf.sssup.it
Thu Jan 29 13:53:13 CET 2009


Hi,

Andy Green wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Somebody in the thread at some point said:
>
> | |  static DECLARE_MUTEX(console_sem);
> | | +#ifdef CONFIG_ANDROID_CONSOLE_EARLYSUSPEND
> | |  static DECLARE_MUTEX(secondary_console_sem);
> | | +#endif
> |
> |> This is a ifndef.
Yes it is wrong, as I say I change it with a ifndef
> | | +#ifndef CONFIG_ANDROID_CONSOLE_EARLYSUSPEND
> | |      if (console_suspended) {
> | |          down(&secondary_console_sem);
>
> Yes but secondary_console_sem only gets defined if
> CONFIG_ANDROID_CONSOLE_EARLYSUSPEND is defined (see what I pasted just
> above), so it's a bug.
>
Yes, I see.
Michael



More information about the openmoko-kernel mailing list