[PATCH] consider alrm->enable in pcf50633_rtc_set_alarm

Balaji Rao balaji at raobalaji.com
Fri Jan 30 07:47:25 CET 2009

On Thu, Jan 29, 2009 at 08:59:49PM -0200, Werner Almesberger wrote:
> Hi Balaji,
> Mickey mentioned to me that he had trouble with the RTC wakeup interrupt.
> I had a quick look at the problem and it seems that alrm->enable doesn't
> get propagated when setting the alarm time with RTC_WKALM_SET.
> Does something like my patch below look right ? We also don't handle
> alrm->pending, but I'm not sure if we have to.

Yes, looks perfect! About alrm->pending, we should be setting it in
read_alarm. But we there's no way to know this from the registers, right ?

Thanks for the patch. Andy can you please apply it to andy-tracking ?

- Balaji

More information about the openmoko-kernel mailing list