[PATCH] fix #if vs. #ifdef cpp warning in neo1973_pm_gps.c

Werner Almesberger werner at openmoko.org
Fri Jan 30 16:16:38 CET 2009


#if is a poor substitute for #ifdef :-)

Signed-off-by: Werner Almesberger <werner at openmoko.org>

---

diff --git a/arch/arm/plat-s3c24xx/neo1973_pm_gps.c b/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
index 6367232..dbaa6eb 100644
--- a/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
+++ b/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
@@ -391,7 +391,7 @@ static ssize_t power_gps_write(struct device *dev,
 	if (!strcmp(attr->attr.name, "power_on")) {
 		gps_pwron_set(on);
 		neo1973_gps.power_was_on = !!on;
-#if CONFIG_PM
+#ifdef CONFIG_PM
 	} else if (!strcmp(attr->attr.name, "keep_on_in_suspend")) {
 		gps_keep_on_in_suspend_set(on);
 #endif



More information about the openmoko-kernel mailing list