[RFC PATCH] bq27000_battery. Retains old value in ETIME error
Michael Trimarchi
trimarchi at gandalf.sssup.it
Thu Jul 30 19:19:55 CEST 2009
Timo Lindfors wrote:
> "Mike Westerhof (mwester)" <mwester at dls.net> writes:
>
>> Shouldn't user-space be alerted to the invalid data, and deal with it in
>> a user-space-specific fashion? It seems to me that this patch is really
>>
>
> Maybe, if the timeouts are not persistent then probably returning
> stale data to userland is ok? For example current_now is updated only
> about every 25 seconds?
>
> However, if the timeouts persist for hours then userland definitely
> should be told about it.
>
> Is there some explanation on why these timeouts happen and how long
> they can last?
>
I can't answer to theese question because I have no idea of the
hardware. The driver
has a bug and I fix it. For me are some shutdown in android system when
it reports no
sufficient battery
Michael
>
>> Maybe we should return "-1" as the value for the fields instead.
>>
>
> This of course means that we need to document this somehow and make
> sure userland developers hear about it and update their code?
>
>
>
>
More information about the openmoko-kernel
mailing list