[PATCH] GTA02: gps power management bugfix
Michael Trimarchi
trimarchi at gandalf.sssup.it
Fri Jun 5 10:17:13 CEST 2009
Paul Fertser wrote:
> After suspending with GPS powered on power_on sysfs node reports 0 and GPS
> is actually unpowered but "echo 1 > power_on" has no effect. This patch
> fixes it.
>
> Reported and analised by Timo Juhani Lindfors <timo.lindfors at iki.fi>,
> ticket #2293.
>
> Signed-off-by: Paul Fertser <fercerpav at gmail.com>
> ---
> arch/arm/plat-s3c24xx/neo1973_pm_gps.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s3c24xx/neo1973_pm_gps.c b/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
> index 93b4911..038a865 100644
> --- a/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
> +++ b/arch/arm/plat-s3c24xx/neo1973_pm_gps.c
> @@ -305,7 +305,7 @@ static void gps_pwron_set(int on)
> /* remove pulldown now it won't be floating any more */
> s3c2410_gpio_pullup(S3C2410_GPH5, 0);
>
> - if (!neo1973_gps.power_was_on)
> + if (!regulator_is_enabled(neo1973_gps.regulator[GTA02_GPS_REG_RF_3V]))
> regulator_enable(neo1973_gps.regulator[
> GTA02_GPS_REG_RF_3V]);
> return;
>
Ok this force the power on, but why you don't force the power off? I
must take a look
to the code.
Michael
More information about the openmoko-kernel
mailing list