[PATCH] GTA0[12]: make headset button report PLAY pressed on press

Nelson Castillo arhuaco at freaks-unidos.net
Wed Jun 10 15:04:50 CEST 2009


On Wed, Jun 10, 2009 at 10:00 AM, Michael 'Mickey'
Lauer<mickey at vanille-media.de> wrote:
> On Tuesday 09 June 2009 18:33:59 Nelson Castillo wrote:
>> On Mon, Jun 8, 2009 at 4:46 PM, Paul Fertser<fercerpav at gmail.com> wrote:
>> > As discussed on the ML, currently headset button reports "KEY_PAUSE
>> > released" on press and "pressed" on release. For "pause" semantics it
>> > makes sense but if someone thinks of that as of just another button, it'd
>> > be good to have "pressed/released" events consistent with button
>> > press/release.
>> >
>> > Luca Capello <luca at pca.it> suggested to change the button event to
>> > KEY_PLAY and to invert the state to make it more consistent.
>> >
>> > This trivial patch inverts button events for GTA03 KEY_PLUS and
>> > KEY_MINUS, i'm not sure how undesirable that is. I can prepare an
>> > alternative that preserves current behaviour on GTA03 per request.
>> >
>> > Signed-off-by: Paul Fertser <fercerpav at gmail.com>
>> >        [NEO1973_KEY_HOLD] = {
>> >                .name = "Neo1973 HOLD button",
>> >                .isr = neo1973kbd_default_key_irq,
>> > -               .input_key = KEY_PAUSE,
>> > +               .input_key = KEY_PLAY,
>>
>> Will this change confuse existing Apps?
>
> There are hardly any apps using this key since you need to fiddle with the alsa
> mixer controls to enable it at all.
>
> This change improves the semantics, +1 for applying it.

It was sent. It's good to read the +1.



More information about the openmoko-kernel mailing list