[PATCH/RFC] Change accelerometers to use ABS events rather than REL events.

Andy Green andy at openmoko.com
Sun Mar 8 22:36:41 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
| [Obviously if this patch is accepted we need to tell developers about
|  it.  I have a number of other improvements to the accelerometers I
|  hope to deliver over the next couple of weeks.  They will have minimal
|  or zero disruption to current code. ]

| -		input_report_rel(lis->input_dev, REL_X, mg_per_sample *
| +		input_report_abs(lis->input_dev, ABS_X, mg_per_sample *

| +	set_bit(EV_ABS, lis->input_dev->evbit);

The accelerations have a relative effect on position, but the
accelerations themselves are absolute it seems.

However, changing it would likely break most of the userspace
accelerometer code for no gain other than correct book-keeping really.

What's the downside of just leaving these as relative?

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkm0OmkACgkQOjLpvpq7dMpA9wCdEWYb8A69bB5T8dbCxqvqVaWx
VDgAnjfaBtGKYjMq2ihdPQHuw1ho05pR
=2CNM
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list