[PATCH] retain gllin compatibility

Werner Almesberger werner at openmoko.org
Thu Mar 26 06:37:36 CET 2009


tim.niemeyer at mastersword.de wrote:
> added pwron attr wich is the same as power_on

Hmm, why ?

> also one typo fixed (3V instead of 3V3 in gps_power_3v_set)

That one looks good. What a mess those regulator variants are :-(

> -		return sysfs_create_group(&pdev->dev.kobj,
> +		ret = sysfs_create_group(&pdev->dev.kobj,
>  		    &gta01_gps_attr_group);
> +		if (!ret)
> +			return bus_create_device_link(&platform_bus_type,
> +					&pdev->dev.kobj, "gta01-pm-gps.0");
>  	}

This looks wrong. If res != 0, we return noise ?

- Werner



More information about the openmoko-kernel mailing list