[PATCH] U-Boot GTA02: Always enable charger on startup

Werner Almesberger werner at openmoko.org
Thu Sep 3 09:20:42 CEST 2009


Rask Ingemann Lambertsen wrote:
>    (Or if you're talking specifically about the wait_for_power() while loop,
> it's not clear to me that the loop will always exit with the charger
> enabled, and even if it does, it's something that could easily be broken by
> accident.)

Ah, now I see. If you take the power-off branch after wait_for_power,
then you're indeed not charging.

The intent might be a little clearer if it wasn't wait_for_power who did
this, but some function called after you return from wait_for_power, but
the logic makes sense to me now.

Thanks,
- Werner



More information about the openmoko-kernel mailing list