updated jitterless kernel patch

Gennady Kupava gb at bsdmn.com
Sun Oct 31 18:14:19 CET 2010


Hi, Neil.

В Вск, 31/10/2010 в 13:54 -0400, Neil Brown пишет:
> On Sun, 31 Oct 2010 16:08:55 +0100
> Riccardo Magliocchetti <riccardo.magliocchetti at gmail.com> wrote:
> 
> > > Patch is not update over previous version, but contains all changes
> > > http://www.bsdmn.com/openmoko/jitterless/jitterless_ts_v3full.patch
> > 
> > There are some style issues:
> > 
> >  >diff --git a/drivers/mfd/glamo-core.c b/drivers/mfd/glamo-core.c
> >  >index 1d51ac1..71d0278 100644
> >  >--- a/drivers/mfd/glamo-core.c
> >  >+++ b/drivers/mfd/glamo-core.c
> >  >@@ -104,6 +104,8 @@ static const struct reg_range reg_range[] = {
> >  > /*	{ 0x1b00, 0x900,	"3D Unit",	0 }, */
> >  > };
> >  >
> >  >+struct glamo_core *default_glamo = 0;
> > 
> > This should be NULL.
> 
> Actually it should just be:
> 
>   static struct glamo_core *default_glamo;
> 
> And the 'extern' should be removed from glamo-core.h

Thanks for comment, but I already removed all instances this struct (see
my latest patch in latest mail), it left only because I didn't look into
resulting patch with enought attention.

> All global and static vars are initialised to zero (I'm not sure if 'C'
> guarantees this, but Linux Kernel does).  

C guarantees this of course.

> so "= 0" or "= NULL" is not
> required and is generally discouraged.

Sure.

> 
> If you './scripts/checkpatch.pl' on the patch it will tell you this and a few
> other things.

Thanks for hint, next time i'll check my patches with it.

Regards,
Gennady






More information about the openmoko-kernel mailing list