[PATCH 4/4] introduce-gta02-beachhead.patch

Sven Rebhan odinshorse at googlemail.com
Fri Feb 20 13:07:09 CET 2009


Hi Andy,

just three comments:

1. Could you please hold this up three more days? I have some build
system fixes that we need for mach-gta02, but I'm not able to send
them before monday.
2. Which revisions of GTA02 are actually in the wild? I'm asking
because it would be nice to further the size of the header (and some
switches). Btw. there are still some GTA02v1definitions in there...
3. What is the data flow when inserting USB? I'm asking because we
startup the loader detection at two different places:

> +static void gta02_pmu_event_callback(struct pcf50633 *pcf, int irq)
> +{
> +       if (irq == PCF50633_IRQ_USBINS) {
> +               schedule_delayed_work(&gta02_charger_work,                        <<-HERE
> +                               GTA02_CHARGER_CONFIGURE_TIMEOUT);
> +               return;
>  ...

and

> +static void gta02_udc_vbus_draw(unsigned int ma)
> +{
> ...
> +       schedule_delayed_work(&gta02_charger_work,                               <<-HERE
> +                               GTA02_CHARGER_CONFIGURE_TIMEOUT);
> ...

Best regards,

    Sven



More information about the openmoko-kernel mailing list